[lua] Stop conquest hourly messages in Dynamis - #11404
Merged
Xaver-DaRed merged 1 commit intoSep 7, 2026
Merged
Conversation
zach2good
approved these changes
Sep 6, 2026
Contributor
|
rebase, please |
Nobutadas
force-pushed
the
no-hourly-conquest-dynamis
branch
from
September 7, 2026 17:12
a310dad to
3091bc8
Compare
Xaver-DaRed
reviewed
Sep 7, 2026
| -- in such cases, owner and influence is undetermined, so we call a city specific method. | ||
| local regionId = zone:getRegionID() | ||
| if regionId > xi.region.TAVNAZIANARCH and regionId < xi.region.DYNAMIS then | ||
| if regionId > xi.region.TAVNAZIANARCH and regionId <= xi.region.DYNAMIS then |
Contributor
There was a problem hiding this comment.
Im pretty sure I told you in discord to remove the function from the zone luas?
So this
Contributor
There was a problem hiding this comment.
If this is just redirecting to yet a different global, just replace one with the other. we dont need to short-circuit this
Contributor
Author
There was a problem hiding this comment.
You did, but that was before I realized it sends the weekly update. Just not the hourly.
That was my mistake in Discord. I didn't test enough at first.
Contributor
Author
There was a problem hiding this comment.
Want me to fix all of the cities while I'm at it?
Nobutadas
force-pushed
the
no-hourly-conquest-dynamis
branch
from
September 7, 2026 18:42
3091bc8 to
8abf171
Compare
Contributor
Author
|
Updated and tested. |
Xaver-DaRed
approved these changes
Sep 7, 2026
Xaver-DaRed
enabled auto-merge
September 7, 2026 19:27
Co-Authored-By: Xaver <60053999+Xaver-DaRed@users.noreply.github.com>
auto-merge was automatically disabled
September 7, 2026 19:28
Head branch was pushed to by a user without write access
Nobutadas
force-pushed
the
no-hourly-conquest-dynamis
branch
from
September 7, 2026 19:28
8abf171 to
ebc2ae6
Compare
Xaver-DaRed
enabled auto-merge
September 7, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
The hourly conquest message shouldn't display in Dynamis, only the weekly message. It behaves just like cities.
Weekly update
Steps to test these changes
Zone into one of the Dynamis zones. Do !updateconquest 0 to see weekly. Watch the hourly tick over.